In the java sdk, CompletablePromiseImpl.cancellableGetImpl allows for a long timeout with a TimeUnit but timeout is treated as milliseconds regardless of the TimeUnit parameter.
@Override public V get(long timeout, TimeUnit unit) throws TimeoutException { return cancellableGetImpl(false, timeout, unit); } @Override public V cancellableGet(long timeout, TimeUnit unit) throws TimeoutException { return cancellableGetImpl(true, timeout, unit); } public V cancellableGetImpl(boolean cancellable, long timeout, TimeUnit unit) throws TimeoutException { if (!completed) { WorkflowInternal.await( Duration.ofMillis(timeout), "Feature.get", () -> { if (cancellable) { CancellationScope.throwCanceled(); } return completed;
edit: add link to github source
1 Like
Vitaly
December 21, 2020, 1:19am
2
Thanks for reporting this issue, I’ve put out a PR to address it:
temporalio:master ← vitarb:apply-time-unit
opened 01:14AM - 21 Dec 20 UTC
1 Like