How can I confirm that dynamic configs are applied?

ktdilsiz · November 14, 2022, 6:39pm

I’m trying to add rate limiting with dynamic configs. I’ve applied the following configs:
(low values are to be able to test easily)

    frontend.globalNamespaceRPS:
      - value: 2

I can see in the logs:
{"level":"info","ts":"2022-11-14T18:12:58.183Z","msg":"Updated dynamic config","logging-call-at":"file_based_client.go:195"}

However, I’m not sure if it actually has my configs are getting applied. Is there some “easy” to test configs? I thought rps-limiting would be easy to test, but it doesn’t seem to work, hence I’m questioning if I was able to apply the configs after all.

ktdilsiz · November 14, 2022, 9:19pm

I found that temporal logs everytime the dynamic config gets updated:

github.com

temporalio/temporal/blob/master/common/dynamicconfig/file_based_client.go#L195


      
          			if err != nil {
          				return err
          			}
          		}
          		newValues[strings.ToLower(key)] = cvs
          	}
          
          
	prev := fc.values.Swap(newValues)
          	oldValues, _ := prev.(configValueMap)
          	fc.logDiff(oldValues, newValues)
          	fc.logger.Info("Updated dynamic config")
          
          
	return nil
          }
          
          
func (fc *fileBasedClient) validateConfig(config *FileBasedClientConfig) error {
          	if config == nil {
          		return errors.New("configuration for dynamic config client is nil")
          	}
          	if _, err := fc.reader.Stat(config.Filepath); err != nil {
          		return fmt.Errorf("dynamic config: %s: %w", config.Filepath, err)

Hence, once we figured out the problem, we started seeing those logs together with difference logs.

Thanks

Topic		Replies	Views
Rate Limiting by namespace Community Support	9	2484	July 18, 2023
Updating Dynamic Config in values.dynamic_config.yaml Community Support helm	4	2039	May 31, 2021
Change RPS limit for operator service Community Support go-sdk	4	52	September 12, 2024
Clarity on config files Community Support	2	1418	January 3, 2023
How to specify dynamic config Community Support	4	3821	December 5, 2020

How can I confirm that dynamic configs are applied?

Related topics