Direct call to NewNoopResolver()

RyanThomas · January 23, 2021, 12:54am

Looks like there is a direct call to NewNoopResolver here:

temporalio/temporal/blob/95c1b5bc336630a79bfad1f29485d4124d637124/tools/cassandra/cqlclient.go#L107


		`WITH replication = { 'class' : 'SimpleStrategy', 'replication_factor' : %v};`
	createKeyspaceNetworkTopologyCQL = `CREATE KEYSPACE IF NOT EXISTS %v ` +
		`WITH replication = { 'class' : 'NetworkTopologyStrategy', '%v' : %v};`
)
var _ schema.DB = (*cqlClient)(nil)
// NewCassandraCluster return gocql clusterConfig
func NewCassandraCluster(cfg *config.Cassandra, timeoutSeconds int) (*gocql.ClusterConfig, error) {
	clusterCfg, err := cassandra.NewCassandraCluster(*cfg, resolver.NewNoopResolver())
	if err != nil {
		return nil, fmt.Errorf("create cassandra cluster from config: %w", err)
	}
	if len(clusterCfg.Hosts) == 0 {
		return nil, errNoHosts
	}
	timeout := time.Duration(timeoutSeconds) * time.Second
	clusterCfg.Timeout = timeout

I implemented the new PersistenceServiceResolver plugin, but when the server tries to start, it goes through:
Server.Start > Server.validate > cassandra.VerifyCompatibleVersion > checkCompatibleVersion > cassandra.newCQLClient

Is this a bug, or am I doing something wrong? Currently this means you can’t make use of PersistenceResolver.

alex · January 23, 2021, 1:30am

This is a bug. Thanks for reporting it. It is ok to use NoopResolver in CLI tools but I didn’t expect server to call anything from the tools/cassandra package.

I will fix it soon.

alex · January 28, 2021, 12:41am

Topic		Replies	Views
Temporal-cassandra-tool is not able to lookup IP Community Support	1	962	March 24, 2021
Temporal server down - Cassandra version compatibility check failed no connections were made when creating the session Server Deployment cassandra	2	709	November 14, 2023
Getting the intermittent "no response received from cassandra within timeout period" Community Support cassandra	1	1169	March 11, 2022
Temporal-cassandra-tool hangs when running validate-health Community Support cassandra	1	678	October 14, 2021
Temporal 1.20.3 "unable to initialize cassandra session" with cql-proxy and astraDb at startup on random pods Community Support cassandra , kubernetes , server	2	1049	November 12, 2023

Direct call to NewNoopResolver()

Related Topics